fix(ActiveSelection): 🔃 `preserveObjectStacking` 📌 #7878

ShaMan123 · 2022-04-15T07:56:50Z

closes #6840
closes #4529

First merge #7859, update from master and then merge this
diff

We should consider a use case that we want a shift click to disregard object stacking.
For now the dev can do one of the following:

listen to the object:added event (we need to keep a constant ref to ActiveSelection for events) - DONE by fix(ActiveSelection): 🚀 multiple nested selection 🗂️ #7882

const activeSel = canvas.getActiveSelection();
activeSel .on('object:added', (object) => {  activeSel.moveObjectToFront(object); });

override _onAfterObjectsChange OR listen to selection:updated and move the object to the front of the stack

TODO

add tests

#7744 (review)

in case object is a collection

github-actions · 2022-05-01T15:38:13Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.1 |    75.96 |   85.78 |   82.82 |                                               
 fabric.js |    83.1 |    75.96 |   85.78 |   82.82 | ...,30868,30942,30953-31018,31141,31240,31476 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

updated from master

github-actions · 2022-05-02T10:34:30Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.12 |    76.03 |   85.77 |   82.84 |                                               
 fabric.js |   83.12 |    76.03 |   85.77 |   82.84 | ...,30877,30951,30962-31027,31150,31249,31485 
-----------|---------|----------|---------|---------|-----------------------------------------------

stale · 2022-06-12T12:56:03Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2022-06-13T06:29:36Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.13 |    76.02 |   85.84 |   82.86 |                                               
 fabric.js |   83.13 |    76.02 |   85.84 |   82.86 | ...,30887,30961,30972-31037,31160,31259,31495 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-16T11:54:56Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.17 |   85.86 |   82.97 |                                               
 fabric.js |   83.23 |    76.17 |   85.86 |   82.97 | ...,30870,30944,30955-31020,31143,31242,31478 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-16T11:56:40Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.23 |    76.17 |   85.86 |   82.97 |                                               
 fabric.js |   83.23 |    76.17 |   85.86 |   82.97 | ...,30870,30944,30955-31020,31143,31242,31478 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-06-16T11:57:31Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.27 |    76.17 |   85.86 |   83.01 |                                               
 fabric.js |   83.27 |    76.17 |   85.86 |   83.01 | ...,30870,30944,30955-31020,31143,31242,31478 
-----------|---------|----------|---------|---------|-----------------------------------------------

stale · 2022-07-10T05:27:06Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-07-30T19:18:09Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-09-21T02:40:42Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ShaMan123 · 2022-11-23T07:55:00Z

src/shapes/active_selection.class.js

@@ -98,6 +98,7 @@
     * @param {fabric.Object[]} targets
     */
    _onAfterObjectsChange: function (type, targets) {
+      this.callSuper('_onAfterObjectsChange', type, targets);


ShaMan123

apart for some insignificant tests in group this PR is ported to #8665

ShaMan123 added 30 commits April 3, 2022 23:32

apply 7744 patch (no binaries)

1a191a7

apply 7744 patch (binaries)

26e8392

commit #7744 review

7d793b3

#7744 (review)

patch2

2708029

Update spray_brush.class.js

02a8ffa

enable text editing under group

0d3690f

migrate back to isDescendantOf

ff0346a

render bg

812f02a

fix(): clear canvas from entire object tree

053946c

in case object is a collection

fix(): center object in case object is nested

db76c44

Update eraser_brush.mixin.js

04aad5b

Update canvas.class.js

8c1c535

Update canvas_events.mixin.js

3fd4af2

lint

58e9be2

safeguard from adding group to itself

c2ef2f5

Update object_ancestry.mixin.js

f0145b5

patch tests from v6!

cb20b81

Update canvas_grouping.mixin.js

347f80d

Update canvas.class.js

a56d55e

Update group_layout.js

2a426e7

Update group_layout.js

5e3fc1f

remove redundant logic

2b1f680

Update canvas_grouping.mixin.js

1ad5cc8

fix(): calling sendPointToPlane

11c828f

Update group.class.js

b6fa3dc

refactor enterGroup

e9afc89

invalidate groups after active selection change

d8f8251

_shouldSetNestedCoords

c58a274

perf(): refrain from contains

c0f5571

Update canvas_events.mixin.js

9a223d0

ShaMan123 commented May 1, 2022

View reviewed changes

Merge branch 'master' into v6-group-patch7

0db189a

stale bot added the stale Issue marked as stale by the stale bot label Jun 12, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Jun 13, 2022

Merge branch 'master' into v6-group-patch7

4fed70c

ShaMan123 added 2 commits June 16, 2022 14:52

Merge branch 'master' into v6-group-patch7

bd0d9f7

Update group.js

9a1cff5

Update group.js

9cc3b18

stale bot added the stale Issue marked as stale by the stale bot label Jul 10, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Jul 10, 2022

stale bot added the stale Issue marked as stale by the stale bot label Jul 30, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Aug 1, 2022

stale bot added the stale Issue marked as stale by the stale bot label Sep 21, 2022

ShaMan123 removed the stale Issue marked as stale by the stale bot label Sep 21, 2022

ShaMan123 commented Nov 23, 2022

View reviewed changes

ShaMan123 added a commit that referenced this pull request Nov 23, 2022

port group changes from #7878

13f6613

ShaMan123 mentioned this pull request Feb 6, 2023

fix(): selection logic to support nested multiselection #8665

Merged

1 task

ShaMan123 commented Feb 6, 2023

View reviewed changes

asturur closed this in #8665 Feb 18, 2023

ShaMan123 deleted the v6-group-patch7 branch February 19, 2023 05:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ActiveSelection): 🔃 `preserveObjectStacking` 📌 #7878

fix(ActiveSelection): 🔃 `preserveObjectStacking` 📌 #7878

ShaMan123 commented Apr 15, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

ShaMan123 left a comment

github-actions bot commented May 2, 2022 •

edited

Loading

stale bot commented Jun 12, 2022

github-actions bot commented Jun 13, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading

stale bot commented Jul 10, 2022

stale bot commented Jul 30, 2022

stale bot commented Sep 21, 2022

ShaMan123 Nov 23, 2022

ShaMan123 left a comment

fix(ActiveSelection): 🔃 preserveObjectStacking 📌 #7878

fix(ActiveSelection): 🔃 preserveObjectStacking 📌 #7878

Conversation

ShaMan123 commented Apr 15, 2022 • edited Loading

TODO

github-actions bot commented May 1, 2022 • edited Loading

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 2, 2022 • edited Loading

Code Coverage Summary

stale bot commented Jun 12, 2022

github-actions bot commented Jun 13, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 16, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 16, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Jun 16, 2022 • edited Loading

Code Coverage Summary

stale bot commented Jul 10, 2022

stale bot commented Jul 30, 2022

stale bot commented Sep 21, 2022

ShaMan123 Nov 23, 2022

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

fix(ActiveSelection): 🔃 `preserveObjectStacking` 📌 #7878

fix(ActiveSelection): 🔃 `preserveObjectStacking` 📌 #7878

ShaMan123 commented Apr 15, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 2, 2022 •

edited

Loading

github-actions bot commented Jun 13, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading

github-actions bot commented Jun 16, 2022 •

edited

Loading