chore(ci): rename option

[ShaMan123]

Minor rename.

I would love to ditch QUnit in favor of something better like chai

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.88 |     75.3 |   86.26 |   82.59 |                                               
 fabric.js |   82.88 |     75.3 |   86.26 |   82.59 | ...,30453,30527,30538-30603,30726,30825,31061 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.89 |    75.33 |   86.26 |    82.6 |                                               
 fabric.js |   82.89 |    75.33 |   86.26 |    82.6 | ...,30453,30527,30538-30603,30726,30825,31061 
-----------|---------|----------|---------|---------|-----------------------------------------------

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[asturur]

I would love to ditch QUnit in favor of something better like chai

Does it run in the browser?
We have 2 sets of test, unit tests and visual one.
Between the unit tests there are some that are more meaningful in the browser ( dom elements and events ).

I would love to have Jest and node only for all the things that are pure functional testing, and have something that can run in the browser for the rest.
QUnit is a bit old and less known, but to be realistic, does it make sense to use time on tests? the website and docs could be at least 10x time better

[ShaMan123]

https://github.com/mochajs/mocha
https://github.com/chaijs/chai
https://github.com/facebook/jest

https://github.com/sinonjs/sinon - stubs!

All these support node/browser.
Jest has more downloads but is under facebook... It can turn into a disadvantage as soon as they loose interest in it. Though it looks very solid. Same as React.
I don't have any preferences.
What I do want is a framework with excellent docs, an easy API and a relatively easy migration (very obvious...).
I think we need something that can mock browser events as well (#7802 needs that for tests). sinon might be able to that, not sure.

I have worked with mocha and sinon in node and was satisfied.

[ShaMan123]

QUnit is a bit old and less known, but to be realistic, does it make sense to use time on tests? the website and docs could be at least 10x time better

10x for sure.

does it make sense to use time on tests?

typo? I don't understand.

[ShaMan123]

BTW we are compromised in the visual tests because of pixel comparison. Empty pixels are accounted for so the percentage for passing the test is wrong. If you run npm test -- -s visual -r you will see how different visuals are in passing tests.
So we should address that as well.