Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): CLI logging and filter option #7844

Merged
merged 12 commits into from
Apr 1, 2022
Merged

feat(ci): CLI logging and filter option #7844

merged 12 commits into from
Apr 1, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Mar 30, 2022

added 2 options:

  1. qunit filter option
  2. disabled logging passing tests by default, show option overrides this. This will end the infinite scrolling on test outputs

It's not perfect but much better

cli

@ShaMan123 ShaMan123 changed the title feat(ci): CLI logging options feat(ci): CLI logging and filter option Mar 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.17 |    76.58 |   86.29 |    82.9 |                                               
 fabric.js |   83.17 |    76.58 |   86.29 |    82.9 | ...,29907,30032,30112-30177,30300,30399,30635 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.22 |    76.62 |   86.29 |   82.95 |                                               
 fabric.js |   83.22 |    76.62 |   86.29 |   82.95 | ...,29907,30032,30112-30177,30300,30399,30635 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.17 |    76.58 |   86.29 |    82.9 |                                               
 fabric.js |   83.17 |    76.58 |   86.29 |    82.9 | ...,29907,30032,30112-30177,30300,30399,30635 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 requested a review from asturur March 30, 2022 08:45
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock is node16+
So if you don't want to commit it you'll need to push a revised one

@asturur
Copy link
Member

asturur commented Apr 1, 2022

packagelog changes for dev deps are not an issue if the ci pass, we have tests on node 14 on purpose

@asturur asturur merged commit 3915894 into master Apr 1, 2022
@ShaMan123 ShaMan123 deleted the cli-log branch April 1, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants