-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(canvas.renderAll
): setDimensions
edge case
#7646
Conversation
renderAll
edge casesetDimensions
edge case
setDimensions
edge casecanvas.renderAll
): setDimensions
edge case
Thanks @yassilah for the excellent repro that made it easy to triage this bug Originally posted by @yassilah in #6112 (comment) |
What the hell was |
So basically after a first resize change, we have been doing non useful redrawing each render cycle. |
@ShaMan123 you should make branch on the main repo, would be easier to add tests for me! |
Thank you this is a great fix |
I have tried in the past. Git goes crazy. Puts branches in headless state and blocks me from working on upstream. |
clone everything in a new folder, maybe that fixes it. |
Happy to have helped! 🙂 |
Yep a good reproducible case is often the best help to expedite things |
Motivation:
#6112
The flag
hasLostContext
is turned on here:fabric.js/src/static_canvas.class.js
Line 602 in a709d3b
And is never turned off.
And that seems to be the problem.
closes #6112