Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path Distance Measurement Inconsistency #7511

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Path Distance Measurement Inconsistency #7511

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79f6208
Path Distance Measurement Inconsistency
Nov 22, 2021
1e499ad
Update path.js
Nov 23, 2021
8f387fa
Update path.js
Nov 23, 2021
5684ec4
Update path.js
Nov 23, 2021
1b8306f
Update path.js
Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/util/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,15 +507,15 @@
p, nextLen, nextStep = 0.01, angleFinder = segInfo.angleFinder, lastPerc;
// nextStep > 0.0001 covers 0.00015625 that 1/64th of 1/100
// the path
while (tmpLen < distance && perc <= 1 && nextStep > 0.0001) {
while (tmpLen < distance && nextStep > 0.0001) {
p = iterator(perc);
lastPerc = perc;
nextLen = calcLineLength(tempP.x, tempP.y, p.x, p.y);
// compare tmpLen each cycle with distance, decide next perc to test.
if ((nextLen + tmpLen) > distance) {
// we discard this step and we make smaller steps.
nextStep /= 2;
perc -= nextStep;
nextStep /= 2;
0xlkda marked this conversation as resolved.
Show resolved Hide resolved
}
else {
tempP = p;
Expand Down