Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EraserBrush): dump canvas bg/overlay color support #7289

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Aug 9, 2021

Motivation

fixes #7220 #7278 by removing erasability support for bg/overlay color

@ShaMan123
Copy link
Contributor Author

Once/If this is merged I'll PR the docs

@asturur
Copy link
Member

asturur commented Aug 13, 2021

This can be probably be supported with some thoughts.
Eventually we can find a way and describe it in a clear example.
The developer can still use a rect, just he has to be aware that the rect has to be as big as the largest level of viewport he wants to use.

@asturur asturur merged commit d45ea00 into fabricjs:master Aug 13, 2021
ShaMan123 added a commit to ShaMan123/fabricjs.com that referenced this pull request Aug 20, 2021
ShaMan123 added a commit to ShaMan123/fabricjs.com that referenced this pull request Aug 20, 2021
@asturur asturur mentioned this pull request Aug 27, 2021
@ShaMan123 ShaMan123 deleted the eraser-dump-canvas-colors branch September 11, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants