Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null pointer error of guidelines #7211

Closed
wants to merge 1 commit into from

Conversation

Implementist
Copy link

  1. Bugfix:When calling canvas.toDataURL after initCenteringGuidelines(canvas) or initAligningGuidelines(canvas) it will cause a “Reference clearRect of null” error.

1. Bugfix:When calling canvas.toDataURL after initCenteringGuidelines(canvas) or initAligningGuidelines(canvas) it will cause a “Reference clearRect of null” error.
@asturur
Copy link
Member

asturur commented Jul 12, 2021

Hi @Implementist can you share how this happen maybe in a jsfiddle? i wonder if the bug is somewhere else.
Your fix is ok, i just want to understand it better

@Implementist
Copy link
Author

Implementist commented Jul 19, 2021

Hi @Implementist can you share how this happen maybe in a jsfiddle? i wonder if the bug is somewhere else.
Your fix is ok, i just want to understand it better

Thanks for your reply. I tried to reproduce this error with simple objects like Rect, Cicle, Text and Line on codepen but got failed. I consider if this problem just happen in more complex canvas (a resume etc.).

The link of my codepen is url

@stale
Copy link

stale bot commented Aug 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Aug 2, 2021
@stale stale bot closed this Aug 10, 2021
@asturur asturur reopened this Aug 13, 2021
@stale stale bot removed the stale Issue marked as stale by the stale bot label Aug 13, 2021
@ShaMan123
Copy link
Contributor

ShaMan123 commented Sep 14, 2022

This was a symptom caused by a race condition between dispose and render - fixed (hopefully for good) by #8220

@ShaMan123 ShaMan123 closed this Sep 14, 2022
@ShaMan123 ShaMan123 removed the feature label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants