fix(shapes): fabric.Object._fromObject never should return #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Jul 16, 2021
| @@ -74,7 +74,7 @@ | |||
| * @param {Function} [callback] Callback to invoke when an fabric.Path instance is created | |||
| */ | |||
| fabric.Polygon.fromObject = function(object, callback) { | |||
| return fabric.Object._fromObject('Polygon', object, callback, 'points'); | |||
| fabric.Object._fromObject('Polygon', object, callback, 'points'); | |||
There was a problem hiding this comment.
can you add return void to this one too?
|
Hi @rockerBOO thanks this is good. Can you address the comment? |
asturur
approved these changes
Jul 16, 2021
|
Thank you for the contribution |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fabric.Object._fromObjectdoesn't return anything, and is processed through the callback.This removes the return and fixes the documentation. This is mostly to upstream this fix to Typescript types as it incorrectly thinks Polygon, Circle, Ellipse return an object.
Thank you!