Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix(fabric.Object): render clipPaths sharper #7186

Closed
wants to merge 1 commit into from

Conversation

asturur
Copy link
Member

@asturur asturur commented Jul 4, 2021

This is an issue we have since 2.4.0, clipPaths don't scale up well with object.
The issue, that is also a lesson, is that with the first round of clipPath release we added too many features ( nested clippaths, absolute clippaths, group of clipPaths ) and we thought we would fix the sharpness later.
Fixing the sharpness and keeping things working is hard, this has been in my to do list for long, i m not sure how to completely solve it and this is just a start.

I need to write a bunch of tests for regression since the one we have are not that much extensive

close #5494

@stale
Copy link

stale bot commented Jul 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jul 19, 2021
@stale stale bot closed this Jul 26, 2021
@asturur asturur reopened this Aug 13, 2021
@stale stale bot removed the stale Issue marked as stale by the stale bot label Aug 13, 2021
@asturur asturur added feature stale Issue marked as stale by the stale bot labels Aug 13, 2021
@stale stale bot removed the stale Issue marked as stale by the stale bot label Aug 13, 2021
@ShaMan123
Copy link
Contributor

This PR has moved to the top of my list.
I think cache canvas needs attention not only for clip paths.
Take a look:
fabric blurry

@ShaMan123
Copy link
Contributor

ShaMan123 commented Oct 11, 2021

What am I missing?
These are custom objects. I don't understand how to get them to render sharper.
The blue object uses an internal text object. I don't understand how to make it sharper.
The math object uses an image. How can fabric take care of scaling images so they render sharper?
Is this related to this PR?
image

@asturur
Copy link
Member Author

asturur commented Oct 11, 2021

no is not strictly realted. But if you want to share one at time, the source code of those custom objects, we can understand what is going on. If you can't disclose, you can send them privately,

@asturur
Copy link
Member Author

asturur commented Mar 28, 2024

replaced by #9774

@asturur asturur closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing objects with a clipPath gives blurry edges
2 participants