Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fabric.Collection): contains -> deep option #7139

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Jun 21, 2021

This PR adds an option to check if an object is deeply contained within a collection.
NON breaking.
Tests passed.

Usage

collection.contains(obj)
collection.contains(obj, true) // deep check

This add an option the check if an object is deeply contained within a collection
Tests passed
@asturur asturur changed the title feat(Collection): contains -> deep option feat(fabric.Collection): contains -> deep option Jun 29, 2021
asturur
asturur previously approved these changes Jun 29, 2021
@asturur
Copy link
Member

asturur commented Jun 29, 2021

can we add a changelog line please?

@ShaMan123
Copy link
Contributor Author

DONE

@asturur asturur merged commit aaf3473 into fabricjs:master Jul 1, 2021
@ShaMan123 ShaMan123 deleted the collection-contains-deep branch July 1, 2021 15:02
@asturur asturur mentioned this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants