Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fabric.Text): underline color with text style ( regression from textpath ) #6974

Merged
merged 5 commits into from
Mar 31, 2021

Conversation

asturur
Copy link
Member

@asturur asturur commented Mar 31, 2021

In refactoring code for textPath a line was butchered.
We need a visual test for this bug, or is not a real fix.

close #6965
close #6818
close #6970

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2021

Code Coverage Summary

> fabric@4.3.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.69 |    76.92 |    85.6 |   82.45 |                                               
 fabric.js |   82.69 |    76.92 |    85.6 |   82.45 | ...,29597,29722,29802-29867,29990,30089,30306 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2021

Code Coverage Summary

> fabric@4.3.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.69 |     76.9 |    85.6 |   82.45 |                                               
 fabric.js |   82.69 |     76.9 |    85.6 |   82.45 | ...,29597,29722,29802-29867,29990,30089,30306 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit e820744 into master Mar 31, 2021
@zhenyakovalyov
Copy link

@asturur heya, could you please advise on when you are planning to release this bit?

@asturur
Copy link
Member Author

asturur commented Apr 6, 2021

i can release it later today, i wanted to add some things but i do not have time

@zhenyakovalyov
Copy link

that is much appreciated!

@asturur asturur mentioned this pull request Apr 7, 2021
@asturur asturur deleted the textlinestyle-regression-issue branch August 8, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants