Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fabric.Canvas): set isMoving on real movement only #6856

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

asturur
Copy link
Member

@asturur asturur commented Feb 7, 2021

close #5378
Set the isMoving boolean only on real movement more than on mousemove event.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

Code Coverage Summary

> fabric@4.3.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.7 |    76.91 |    85.6 |   82.46 |                                               
 fabric.js |    82.7 |    76.91 |    85.6 |   82.46 | ...,29558,29683,29763-29828,29951,30050,30267 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit bfced5b into master Feb 7, 2021
@asturur asturur mentioned this pull request Apr 7, 2021
@asturur asturur deleted the fix-border-opacity branch August 8, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Borders enter transparent state immediately on select
1 participant