Fixed SvgExport in path with gradient and added tests #6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pr is good! thanks. |
asturur
approved these changes
Oct 17, 2020
Merged
shanicerae
pushed a commit
to shanicerae/fabric.js
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a problem in fabric with the svg export for a percentage based gradient on a path element. Here is a comparison between the rendering on canvas and in the exported svg:
https://codesandbox.io/s/clever-mountain-u0fxv?file=/src/index.js
When removing the subtraction of pathOffset from offset in the
toSvgfunction of thegradientwith the unitpercentage, the exported svg looks like the rendering on canvas, as can be seen in this codesandbox:https://codesandbox.io/s/nice-vaughan-l3sj4?file=/src/index.js
I added two visual tests to this PR, the first one tests if the gradient is correctly rendered on canvas and succeeds also for the current version. The second one tests the exported svg image and only succeeds with my changes. I am not sure if these tests are in the correct files or are performed at the right position. I could not find any guidelines for creating visual tests.