Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix itext clear area #3388

Merged
merged 3 commits into from
Oct 29, 2016
Merged

fix itext clear area #3388

merged 3 commits into from
Oct 29, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Oct 29, 2016 •
edited
Loading

close #3378
close #3386

issue #3378 highlight 2 problems:

  1. the context top was cleared every render cycle, even when it was already clear.
  2. itext was clearing the wrong area.
    issue IText character background producing unwanted lines when created with small font size #3386 highlight a defect in rendering of transparent gb in itext style.

This pr solve the issues in thisway

  1. context top get flagged as dirty when we draw the selection over it
  2. itext clear is area BEFORE start a new render cycle.

@asturur asturur merged commit 17ad789 into master Oct 29, 2016
asturur added a commit that referenced this pull request Oct 29, 2016
@asturur
fix itext clear area (#3388)
ad714d4 
* fix itext clear area
* fix overlapping bg colors

* do not commit dist
@asturur asturur deleted the itextclear branch November 13, 2016 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@asturur