Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retina scaling shadows and data url #2806

Merged
merged 8 commits into from
Mar 1, 2016
Merged

Fix retina scaling shadows and data url #2806

merged 8 commits into from
Mar 1, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Feb 24, 2016

Do not pull untill confirmation screenshots.

closes #2801
closes #2744

Add retina scaling as a normal dataurl multiplier.
Removed setWidth and setHeight in favor of setDimensions
Removed rescaling back of canvas because setDimension will clear the transform anyway.
@asturur
Copy link
Member Author

asturur commented Feb 24, 2016

canvas to dataUrl:
image

original canvas:
image

looks like that if i'm setting fabric.devicePixelRation = 2, the dataUrl export effectively produce a double size canvas and shadows are correct.
@kangax you can merge for me.

kangax added a commit that referenced this pull request Mar 1, 2016
Fix retina scaling shadows and data url
@kangax kangax merged commit 1324c73 into fabricjs:master Mar 1, 2016
@asturur asturur deleted the fix-retina-again branch March 26, 2016 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants