chore(TS): Update Typescript to 5.5.4

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [next]
 
+- chore(TS): Update TS to latest [#10044](https://github.com/fabricjs/fabric.js/pull/10044)
 - feat(): Add has method to classRegistry to allow to check if a class exists. (fixes #10001)
 
 ## [6.1.0]

package.json

@@ -117,12 +117,12 @@
     "prettier": "2.7.1",
     "ps-list": "^8.1.0",
     "qunit": "^2.17.2",
-    "rollup": "^4.9.5",
+    "rollup": "^4.20.0",
     "semver": "^7.3.8",
     "source-map-support": "^0.5.21",
     "testem": "^3.8.0",
     "tslib": "^2.4.1",
-    "typescript": "^4.9.4",
+    "typescript": "^5.5.4",
     "v8-to-istanbul": "^9.1.0"
   },
   "engines": {

src/EventTypeDefs.ts

@@ -348,6 +348,6 @@ export interface CanvasEvents
   // IText
   'text:selection:changed': { target: IText };
   'text:changed': { target: IText };
-  'text:editing:entered': { target: IText };
+  'text:editing:entered': { target: IText } & Partial<TEvent>;
   'text:editing:exited': { target: IText };
 }

src/Shadow.ts

@@ -126,12 +126,7 @@ export class Shadow {
   constructor(arg0: string | Partial<TClassProperties<Shadow>>) {
     const options: Partial<TClassProperties<Shadow>> =
       typeof arg0 === 'string' ? Shadow.parseShadow(arg0) : arg0;
-    Object.assign(this, Shadow.ownDefaults);
-    for (const prop in options) {
-      // @ts-expect-error for loops are so messy in TS
-      this[prop] = options[prop];
-    }
-
+    Object.assign(this, Shadow.ownDefaults, options);
     this.id = uid();
   }
 

src/canvas/DOMManagers/util.ts

@@ -1,4 +1,4 @@
-import { LEFT, NONE, TOP } from '../../constants';
+import { NONE } from '../../constants';
 import type { TSize } from '../../typedefs';
 import {
   getDocumentFromElement,
@@ -50,25 +50,21 @@ export const setCSSDimensions = (
  * @return {Object} Object with "left" and "top" properties
  */
 export function getElementOffset(element: HTMLElement) {
-  let box = { left: 0, top: 0 };
   const doc = element && getDocumentFromElement(element),
-    offset = { left: 0, top: 0 },
-    offsetAttributes = {
-      borderLeftWidth: LEFT,
-      borderTopWidth: TOP,
-      paddingLeft: LEFT,
-      paddingTop: TOP,
-    } as const;
+    offset = { left: 0, top: 0 };
 
   if (!doc) {
     return offset;
   }
-  const elemStyle =
-    getWindowFromElement(element)?.getComputedStyle(element, null) || {};
-  for (const attr in offsetAttributes) {
-    // @ts-expect-error TS learn to iterate!
-    offset[offsetAttributes[attr]] += parseInt(elemStyle[attr], 10) || 0;
-  }
+  const elemStyle: CSSStyleDeclaration =
+    getWindowFromElement(element)?.getComputedStyle(element, null) ||
+    ({} as CSSStyleDeclaration);
+  offset.left += parseInt(elemStyle.borderLeftWidth, 10) || 0;
+  offset.top += parseInt(elemStyle.borderTopWidth, 10) || 0;
+  offset.left += parseInt(elemStyle.paddingLeft, 10) || 0;
+  offset.top += parseInt(elemStyle.paddingTop, 10) || 0;
+
+  let box = { left: 0, top: 0 };
 
   const docElem = doc.documentElement;
   if (typeof element.getBoundingClientRect !== 'undefined') {

src/filters/BaseFilter.ts

@@ -387,8 +387,7 @@ export class BaseFilter<
     return {
       type: this.type,
       ...defaultKeys.reduce<OwnProps>((acc, key) => {
-        //@ts-expect-error TS doesn't get i want an object that looks like this
-        acc[key] = this[key as keyof this];
+        acc[key] = this[key as keyof this] as unknown as typeof acc[typeof key];
         return acc;
       }, {} as OwnProps),
     };