Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toSVG undesirable trailing space on text-decoration="underline " #6205

Closed
ilbrigz opened this issue Mar 5, 2020 · 1 comment · Fixed by #6209
Closed

toSVG undesirable trailing space on text-decoration="underline " #6205

ilbrigz opened this issue Mar 5, 2020 · 1 comment · Fixed by #6209
Labels
bug fix-next

Comments

@ilbrigz
Copy link

ilbrigz commented Mar 5, 2020

Version

3.6.0

Test Case

http://jsfiddle.net/ilbrigz/eu694kjb/1/

Information about environment

Browser

Expected Behavior

toSVG() to add
text-decoration="underline"
prop to svgs

Actual Behavior.

toSVG() adds
text-decoration="underline "
with a trailing space after the underline. Could be problematic when using the svg with other libraries
@asturur
Copy link
Member

asturur commented Mar 8, 2020

i think is still in specs, but i have no problem fixing it.
Why do you think the space is undesirable?

@asturur asturur mentioned this issue Mar 8, 2020
Merged
asturur added a commit that referenced this issue Mar 8, 2020
@asturur
fix(svg_export): remove extra space from svg export #6205 (#6209)
68907ef
asturur added a commit that referenced this issue Mar 9, 2020
@asturur
fix(svg_export): remove extra space from svg export #6205 (#6209)
b242702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fix-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-6205, remove extra space from svg export fabricjs/fabric.js
2 participants
@asturur @ilbrigz