During load from json send error to reviver (#3586)

* send error to reviver * add error to imageFromObject
fabricjs · Dec 26, 2016 · da25301 · da25301
1 parent 700ee14
commit da25301
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/shapes/image.class.js b/src/shapes/image.class.js
@@ -628,7 +628,11 @@
    * @param {Function} callback Callback to invoke when an image instance is created
    */
   fabric.Image.fromObject = function(object, callback) {
-    fabric.util.loadImage(object.src, function(img) {
+    fabric.util.loadImage(object.src, function(img, error) {
+      if (error) {
+        callback && callback(null, error);
+        return;
+      }
       fabric.Image.prototype._initFilters.call(object, object.filters, function(filters) {
         object.filters = filters || [];
         fabric.Image.prototype._initFilters.call(object, object.resizeFilters, function(resizeFilters) {

diff --git a/src/util/misc.js b/src/util/misc.js
@@ -328,10 +328,8 @@
         var klass = fabric.util.getKlass(o.type, namespace);
         if (klass.async) {
           klass.fromObject(o, function (obj, error) {
-            if (!error) {
-              enlivenedObjects[index] = obj;
-              reviver && reviver(o, enlivenedObjects[index]);
-            }
+            enlivenedObjects[index] = obj;
+            reviver && reviver(o, enlivenedObjects[index], error);
             onLoaded();
           });
         }