This repository has been archived by the owner on Nov 6, 2018. It is now read-only.
Updated apiVersion for SecurityContextConstraints #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 17, 2018
|
Ok to test |
|
retest this please |
|
@oscerd I think there is some problem with CI, it gives Java Heap Space- Out of Memory Error. But it locally gets build. |
hrishin
approved these changes
Jan 18, 2018
This was referenced Jan 18, 2018
rohanKanojia
approved these changes
Jan 18, 2018
|
retest this please |
1 similar comment
|
retest this please |
|
Van you rebase this one too? |
to set the default apiVersion to v1
|
It seems that retest doesn't work. I tried to replay the build from UI bit it still take the old heap setting |
|
Rebase done, let's see |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a case while generating SecurityContextConstraints
to set the default apiVersion to v1
This will also fix the SecurityContextConstraints problem in Kubernetes Client
#962