Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail in AbstractWatchManager.onMessage #5700

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

fvasco
Copy link

@fvasco fvasco commented Jan 10, 2024

Port of changes described here: #5692 (comment)

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine to me. @shawkins, any thoughts?

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fvasco for the pr, do you mind making a few refinements?

@fvasco
Copy link
Author

fvasco commented Jan 11, 2024

@shawkins I did it.

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fvasco
Copy link
Author

fvasco commented Jan 16, 2024

What is missing for merge?

@manusa manusa added this to the 6.11.0 milestone Jan 16, 2024
…a status

Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Copy link

@manusa manusa merged commit efbd20e into fabric8io:main Jan 17, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants