-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detail in AbstractWatchManager.onMessage #5700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems fine to me. @shawkins, any thoughts?
...tes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/AbstractWatchManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fvasco for the pr, do you mind making a few refinements?
@shawkins I did it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is missing for merge? |
…a status Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Port of changes described here: #5692 (comment)