Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set bignumbermode when creating tar for upload to pod #5186

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

sorend
Copy link

@sorend sorend commented May 31, 2023

Description

Set bignumbermode when creating tar files for uploading to pod.

Bignumbermode is required to support large UIDs, which are commonly used on e.g. Openshift.

Integration tests already do the same thing:

tarArchiveOutputStream.setBigNumberMode(TarArchiveOutputStream.BIGNUMBER_POSIX);

Type of change

Bugfix, to avoid this type of error:

Caused by: java.lang.IllegalArgumentException: user id '1000990000' is too big ( > 2097151 ).
	at org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.failForBigNumber(TarArchiveOutputStream.java:406)
	at org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.failForBigNumber(TarArchiveOutputStream.java:400)
	at org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.failForBigNumbers(TarArchiveOutputStream.java:418)
	at org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.putArchiveEntry(TarArchiveOutputStream.java:592)
	at io.fabric8.kubernetes.client.dsl.internal.uploadable.PodUpload.addFileToTar(PodUpload.java:178)
  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

@manusa manusa added this to the 6.7.0 milestone May 31, 2023
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check failing tests

@manusa manusa modified the milestones: 6.7.0, 6.8.0 May 31, 2023
@sunix
Copy link
Collaborator

sunix commented Jul 4, 2023

@sorend would it be possible to update the PR (rebase to master)? Let us know

@sunix sunix added the Waiting on feedback Issues that require feedback from User/Other community members label Jul 4, 2023
@manusa manusa self-assigned this Jul 18, 2023
@manusa manusa force-pushed the fix/create-tar-bignumber-mode branch from 1ad405e to 850cf5b Compare July 19, 2023 11:47
@manusa manusa removed the Waiting on feedback Issues that require feedback from User/Other community members label Jul 19, 2023
@manusa manusa force-pushed the fix/create-tar-bignumber-mode branch 7 times, most recently from 81087c4 to 018350a Compare July 19, 2023 16:07
manusa added 2 commits July 19, 2023 18:26
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the fix/create-tar-bignumber-mode branch from 018350a to a82440c Compare July 19, 2023 16:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 871863d into fabric8io:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants