-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set bignumbermode when creating tar for upload to pod #5186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorend
requested review from
manusa,
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
May 31, 2023 06:40
manusa
approved these changes
May 31, 2023
oscerd
approved these changes
May 31, 2023
rohanKanojia
approved these changes
May 31, 2023
manusa
requested changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check failing tests
@sorend would it be possible to update the PR (rebase to master)? Let us know |
sunix
added
the
Waiting on feedback
Issues that require feedback from User/Other community members
label
Jul 4, 2023
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
fix/create-tar-bignumber-mode
branch
from
July 19, 2023 11:47
1ad405e
to
850cf5b
Compare
manusa
removed
the
Waiting on feedback
Issues that require feedback from User/Other community members
label
Jul 19, 2023
manusa
approved these changes
Jul 19, 2023
manusa
force-pushed
the
fix/create-tar-bignumber-mode
branch
7 times, most recently
from
July 19, 2023 16:07
81087c4
to
018350a
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
fix/create-tar-bignumber-mode
branch
from
July 19, 2023 16:34
018350a
to
a82440c
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set bignumbermode when creating tar files for uploading to pod.
Bignumbermode is required to support large UIDs, which are commonly used on e.g. Openshift.
Integration tests already do the same thing:
kubernetes-client/kubernetes-itests/src/test/java/io/fabric8/openshift/BuildIT.java
Line 125 in f6ea58c
Type of change
Bugfix, to avoid this type of error:
test, version modification, documentation, etc.)