Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw Handling #4409

Closed
wants to merge 2 commits into from
Closed

Raw Handling #4409

wants to merge 2 commits into from

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Sep 8, 2022

Description

Here's a draft of consistently handling the raw type as object as described in #4289. This is as far as things will generate before you hit some compile errors as the buildable logic won't add the relevant subtype methods like it would for HasMetadata. Without changes to sundrio this is more breaking that I would have hoped for - ideally the subtypes would only include KubernetesResources.

I'm not sure how viable it would be (either at the pojo generation level or sundrio), but the next attempt would be to map to KuberentesResource but also add a generated method that allow the use of Map.

cc @manusa @iocanel

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins
Copy link
Contributor Author

Closing because this doesn't seem viable.

@shawkins shawkins closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant