Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default ObjectMetadata and maps #4160

Merged
merged 3 commits into from
May 23, 2022
Merged

Added default ObjectMetadata and maps #4160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c896128
fix #3625: updating the default logic for maps and objectmetadata
shawkins May 18, 2022
99ca756
fix #3625: committing the modifications made by the generator
shawkins May 18, 2022
12ec5f4
fix #3625: test corrections related to having non-null values
shawkins May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#### Improvements
* Remove `setIntVal`, `setStrVal`, `setKind` setters from `IntOrString` class to avoid invalid combinations
* Fix #3625: ObjectMetadata and its annotations and labels are non-null by default.
* Fix #3852: Deserializing kamelets fails with UnrecognizedPropertyException
* Fix #3889 : remove piped stream for file download
* Fix #1285: removed references to manually calling registerCustomKind
Expand Down
10 changes: 10 additions & 0 deletions doc/MIGRATION-v6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Migration from 5.x to 6.x

## Contents:
- [ObjectMetadata](#objectmetadata)
- [Backwards Compatibility Interceptor](#backwards-compatibility-interceptor)
- [Namespace Changes](#namespace-changes)
- [API/Impl split](#api-impl-split)
Expand All @@ -19,6 +20,15 @@
- [Delete Behavior](#delete-behavior)
- [Stream Changes](#stream-changes)

## ObjectMetadata

ObjectMetadata will default to a non-null value. All Maps in the generated object models, including ObjectMetadata.annotations and labels will also be non-null by default. A small behavioral difference is that the default value will be omitted from serialization, previously if you did something like
```
Pod p = new Pod();
p.setMetadata(new ObjectMetadata());
```
p would serialize with "metadata: {}" - that will now be omitted.

## Backwards Compatibility Interceptor

kubernetes.backwardsCompatibilityInterceptor.disable now defaults to true, rather than false. If you need backwards compatibility support, please set this property to false.
Expand Down
Loading