Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tekton Pipeline model to 0.17.0 #2535

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

jeffmaury
Copy link
Contributor

@jeffmaury jeffmaury commented Oct 9, 2020

Fixes #2534

Adds

  • WhenExpressions
  • Optional workspaces

Signed-off-by: Jeff MAURY jmaury@redhat.com

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Fixes fabric8io#2534

Adds
- WhenExpressions
- Optional workspaces

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@centos-ci
Copy link

Can one of the admins verify this patch?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia requested a review from manusa October 9, 2020 15:55
@rohanKanojia
Copy link
Member

@Fabian-K : Could you please review this whenever you get some time?

Copy link
Contributor

@Fabian-K Fabian-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jeffmaury!

@rohanKanojia
Copy link
Member

@Fabian-K @jeffmaury : Thanks to your awesome contributions, this extension is getting better and better! I think we now have pretty good/complete support with respect to Tekton REST API.

I think it would be awesome if we had some cool blog posts on how this extension is becoming useful for Java devs who want to access Tekton API. Does anyone have any plans to write a blog post about it?

@jeffmaury
Copy link
Contributor Author

Not sure I have time to do it but I can write a blog post about the latest changes in our IntelliJ Tekton plugin that uses the Tekton F8 client.

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!!

@manusa
Copy link
Member

manusa commented Oct 13, 2020

[merge]

1 similar comment
@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit fb723a4 into fabric8io:master Oct 13, 2020
@Fabian-K
Copy link
Contributor

I think it would be awesome if we had some cool blog posts on how this extension is becoming useful for Java devs who want to access Tekton API. Does anyone have any plans to write a blog post about it?

Agree, this would be really cool. So far I never wrote a blog post and tbh I don´t think this will change in the near future. If you plan to do something and need feedback let me know :)

@rohanKanojia
Copy link
Member

I had written a blog post a week ago about it: https://itnext.io/access-tekton-pipelines-in-java-using-fabric8-tekton-client-bd727bd5806a . Maybe you can provide feedback on this :-) .

But to be honest, I'm not really a tekton guy; I'm not using tekton for anything. I'm not sure this blog post covers use cases regular tekton users might be looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tekton extension does not support When expressions
7 participants