Fix #1246: Separate stderr and stdout streams in ExecWebSocketListener #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
oscerd
approved these changes
Nov 16, 2018
|
Can you please rebase? |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246 - brief summary of issue: the exec listener was changed to combine stderr with stdout
This PR just reverts those changes so that stderr is properly written to the stderr stream and kept separate from stdout.
If adding a simple way for people to use the exec api through the client would be useful, @PaulFurtado described what we've written to do this in this comment. We'd be happy to take a look at adding something similar to the client.