Add support for Kubernetes RBAC ClusterRoles and ClusterRoleBindings #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
oscerd
approved these changes
Jul 23, 2018
|
[merge] |
piyush-garg
reviewed
Jul 23, 2018
| @@ -25,6 +25,8 @@ io.fabric8.kubernetes.client.handlers.HorizontalPodAutoscalerHandler | |||
| io.fabric8.kubernetes.client.handlers.IngressHandler | |||
| io.fabric8.kubernetes.client.handlers.KubernetesRoleBindingHandler | |||
| io.fabric8.kubernetes.client.handlers.KubernetesRoleHandler | |||
| io.fabric8.kubernetes.client.handlers.KubernetesClusterRoleBindingHandler | |||
| io.fabric8.kubernetes.client.handlers.KubernetesClusterRoleHandler | |||
There was a problem hiding this comment.
This should be in alphabetical order
There was a problem hiding this comment.
Thanks. It should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thsi PR adds support for ClusterRole and ClusterRoleBinding from Kubernetes API. The code changes should be very similar to #1111 - the main difference being that Cluster Role and Cluster Role Binding are not namespaced resources.
This PR should fix issue #1150