Fix ignored context when using kubeconfig #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This missing context seems to come from this commit. LGTM |
oscerd
approved these changes
Jul 19, 2018
|
ok to test. Maybe @igalarzab add a note on the CHANGELOG, just to track the fix. |
|
done :) |
|
Thanks :-) |
oscerd
approved these changes
Jul 19, 2018
rohanKanojia
approved these changes
Jul 19, 2018
oscerd
approved these changes
Jul 23, 2018
|
[merge] |
piyush-garg
reviewed
Jul 23, 2018
| @@ -3,6 +3,8 @@ | |||
| #### 4.0.4 (To be released) | |||
| Bugs | |||
|
|
|||
| * Fix #1147: Cluster context was being ignored when loading the Config from a kubeconfig file | |||
There was a problem hiding this comment.
There is no issue number 1147
There was a problem hiding this comment.
it's the ID of the PR, not the issue (I don't know why I thought they were shared): #1147
They actually redirect: https://github.com/fabric8io/kubernetes-client/issues/1147
There was a problem hiding this comment.
But it should be a issue Number, you fix an issue so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.