This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
QuarkusGenerator: Extract base image from config or fallback to default. #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
============================================
+ Coverage 34.39% 34.55% +0.15%
- Complexity 1129 1135 +6
============================================
Files 190 191 +1
Lines 10829 10900 +71
Branches 1763 1767 +4
============================================
+ Hits 3725 3766 +41
- Misses 6661 6688 +27
- Partials 443 446 +3 |
|
@juazugas : Thanks a lot for this PR 👍 Could you please run a |
rohanKanojia
approved these changes
Nov 4, 2019
oscerd
approved these changes
Nov 4, 2019
devang-gaur
approved these changes
Nov 4, 2019
rohanKanojia
added
the
jkube/pending
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 7, 2019
rohanKanojia
removed
the
jkube/pending
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 27, 2019
rohanKanojia
added a commit
to eclipse-jkube/jkube
that referenced
this pull request
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying in the configuration for the Quarkus generator the base image of the container.
This change extracts the configured key
fromfor the generator or reads the propertyfabric8.generator.fromto use it as a base image for the container.It also fallbacks to the default values in case any is provided.