Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

fat jar wrongly detected on simple jar #1776

Closed
seboudry opened this issue Jan 9, 2020 · 0 comments · Fixed by #1781
Closed

fat jar wrongly detected on simple jar #1776

seboudry opened this issue Jan 9, 2020 · 0 comments · Fixed by #1781
Assignees
Labels
cat/bug Bug which needs fixing

Comments

@seboudry
Copy link

seboudry commented Jan 9, 2020

Description

Using a simple jar packaging (with Spring-Boot in my case), fabric8-maven-plugin incorrectly detect it as a fat-jar.

After looking on recent fmp code changes, I noticed this Main Class test deletion
7795450#diff-6381c00c0fdfd17f4c36d06e76549dcfL61

Is it really wanted for JIB support?

Info

  • f-m-p version : 4.3.1
  • Maven version (mvn -v) :
Apache Maven 3.6.1
Maven home: /usr/share/maven
Java version: 1.8.0_232, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.3.0-24-generic", arch: "amd64", family: "unix"
  • Kubernetes / OpenShift setup and version : N/A

mvn install

Absence of [INFO] F8: spring-boot: Detected main class com.acme.foo.Application
On builded container: /deployment only contains simple jars and not all jar dependencies
When running it: no main manifest attribute, in /deployments/foo.jar

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/bug Bug which needs fixing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants