Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Integrate Dekorate into fmp #1483

Closed
rhuss opened this issue Jan 9, 2019 · 5 comments
Closed

Integrate Dekorate into fmp #1483

rhuss opened this issue Jan 9, 2019 · 5 comments
Assignees
Labels
cat/feature Feature request size/l Large status/never-stale Pin this issue to get never marked as stale by stale-bot target/4.0 PR for targeted to 4.0.x

Comments

@rhuss
Copy link
Contributor

rhuss commented Jan 9, 2019

Integrate ap4k (annotation based resource configuration)

See https://github.com/ap4k/ap4k/tree/master/examples/spring-boot-with-fmp-on-kubernetes-example for a simple example. Maybe this is already good enough.

@iocanel wdyt what's needed for a good ap4k integration into fmp ?

@rohanKanojia rohanKanojia added cat/feature Feature request target/4.0 PR for targeted to 4.0.x size/l Large status/never-stale Pin this issue to get never marked as stale by stale-bot labels Jan 10, 2019
@iocanel
Copy link
Member

iocanel commented Jan 10, 2019

It's close but not there. I'd prefer an approach where the user didn't have to specify the @Generator.

Ideally, ap4k could provide an alternative to the @GeneratorOptions via system properties and fmp could just set those.

@cmoulliard
Copy link
Contributor

Have you documented how to use such property system @iocanel ?

@rohanKanojia rohanKanojia changed the title Integrate ap4k into fmp Integrate Dokorate into fmp Nov 14, 2019
@rohanKanojia
Copy link
Member

The project has been renamed to Dekorate and is available here: https://github.com/dekorateio/dekorate

@iocanel iocanel changed the title Integrate Dokorate into fmp Integrate Dekorate into fmp Nov 14, 2019
@manusa
Copy link
Member

manusa commented Nov 18, 2019

Recording of meeting regarding this topic can be found here:
https://bluejeans.com/playback/s/SlaPpPDBTBmlJwZvsXsiHrh7y1n8hJfNvTz2VSg2RBQpHtCaHXywaG87SkcHfGTV

@manusa manusa self-assigned this Dec 3, 2019
manusa added a commit to marcnuri-forks/fabric8-maven-plugin that referenced this issue Jan 3, 2020
manusa added a commit to marcnuri-forks/fabric8-maven-plugin that referenced this issue Jan 17, 2020
manusa added a commit to marcnuri-forks/fabric8-maven-plugin that referenced this issue Jan 17, 2020
rohanKanojia added a commit to marcnuri-forks/fabric8-maven-plugin that referenced this issue Jan 21, 2020
rohanKanojia added a commit that referenced this issue Jan 22, 2020
@manusa
Copy link
Member

manusa commented Jan 29, 2020

Integration is now ready and available both in FMP and JKube.

@manusa manusa closed this as completed Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature Feature request size/l Large status/never-stale Pin this issue to get never marked as stale by stale-bot target/4.0 PR for targeted to 4.0.x
Projects
None yet
Development

No branches or pull requests

5 participants