change buildAndLoadNativePlatform to buildAndLoadSinglePlatform #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marsette Vona <martyvona@gmail.com>
|
LGTM. @rohanKanojia, feel free to merge. |
Codecov Report
@@ Coverage Diff @@
## master #1665 +/- ##
=========================================
Coverage 63.85% 63.86%
- Complexity 2184 2185 +1
=========================================
Files 170 170
Lines 9947 9949 +2
Branches 1363 1364 +1
=========================================
+ Hits 6352 6354 +2
Misses 3062 3062
Partials 533 533
|
|
@martyvona : Thanks, Could you please add a test and a line to doc/changelog.md regarding this change? |
Signed-off-by: Marsette Vona <martyvona@gmail.com>
Signed-off-by: Marsette Vona <martyvona@gmail.com>
Signed-off-by: Marsette Vona <martyvona@gmail.com>
|
@rohanKanojia done |
|
Kudos, SonarCloud Quality Gate passed! |
|
@rohanKanojia ready to merge |
rohanKanojia
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables building a single-platform image with an architecture that differs from the native platform. For example, if you're build machine is an arm M1 but you need to test and deploy amd64. Note that while docker currently does not support multi-architecture images in the local image cache, it will use emulation to run e.g. an amd64 image on an arm host.
This is in follow up to #1557 (comment)