Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing undesirable behavior in local jupyter notebook SSH command template #401

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ibaldin
Copy link
Contributor

@ibaldin ibaldin commented Feb 3, 2025

if I create a fabric_rc with SSH connection template that points to my local fabric SSH config file, and source this file, this setting doesn't take effect if I just do

fablib = fablib_manager()             
fablib.show_config();

(it keeps pointing to what would be my jupyter hub work directory) . I have to do

fablib = fablib_manager(fabric_rc='/path/to/fabric_rc')             
fablib.show_config();

for it to work.I think the attached patch fixes this behavior.

…nd template set via environment variable is ignored if the fabric RC file is sourced
@ibaldin ibaldin requested a review from kthare10 February 3, 2025 19:02
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@kthare10 kthare10 merged commit 458d418 into main Feb 3, 2025
20 of 21 checks passed
@kthare10 kthare10 deleted the local-ssh-fix-ib branch February 3, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants