Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating godeps #969

Merged
merged 1 commit into from
Feb 13, 2025
Merged

updating godeps #969

merged 1 commit into from
Feb 13, 2025

Conversation

aleksraiden
Copy link
Contributor

Update godeps to latest (as possible).

Currently, fabio deps cant be updated directly, like go get -u ./... because we have two "points-of-pain":

A first - armon/go-proxyproto and inetaf/tcpproxy cant be upgraded

Second - a part, working with zipkin and tracing. A newest version of tracing have a lot of changes in API, so we need a rewrite core logic into tracing module and test. A package, affected this: openzipkin-contrib/zipkin-go-opentracing, openzipkin/zipkin-go and apache/thrift.

@tristanmorgan
Copy link
Member

On a side note, I've been looking at replacing github.com/armon/go-proxyproto with github.com/pires/go-proxyproto but I have a troubling test to get working.

Copy link
Member

@tristanmorgan tristanmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well, Thanks for the contribution.

@tristanmorgan tristanmorgan merged commit 0f7da1e into fabiolb:master Feb 13, 2025
1 check passed
@aleksraiden aleksraiden deleted the update-deps-43 branch February 14, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants