fix notification sent twice bug when printing with octolapse (#13) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nline#13) add check to make sure that `new_z` height is always more than zero, this prevents the plugin to send the same notification twice Changes to be committed: modified: octoprint_telegram/telegramNotifications.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing with the Octolapse plugin enabled, the
msgZChangeand so theis_notification_necessaryroutine is executed twice, resulting in a double notification sent by OctoPrint-Telegram. As checks to prevent sending a notification when the new Z value is negative was missing, this pull request aim to both fix the bug mentioned in #13 (the part regarding Octolapse) and adding this data consistency check.This will not fix the whole bug, as the maintainer reported in the aforementioned issue, the instruction
new_z < self.last_zmay be removed, but I defer to his judgment.