Fixed image rotation, fixed 2 typos #287
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my fix on PR #242 mirrored images for others and it's been reverted in #268, my images are now being wrongly flipped again.
I searched trough
PIL.Image
documentation and I found thatrotate()
rotates CCW, as OctoPrint states in the options:The documentation states that
rotate()
andtranspose()
operations are interoperable:so the rotation needed to match OctoPrint's behaviour is
Image.ROTATE_90
, notImage.ROTATE_270
.This explains the correct behaviour I got with my old PR #242 with the rotation + vertical and horizontal flipping.
With
Image.ROTATE_90
I'm now getting the same image while rotating and flipping in any combination