Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRS improvements #2154

Merged
merged 1 commit into from
Jan 26, 2025
Merged

DRS improvements #2154

merged 1 commit into from
Jan 26, 2025

Conversation

rfomin
Copy link
Collaborator

@rfomin rfomin commented Jan 26, 2025

  • Added 30-frame history and 15-frame cooldown period after resolution change.

  • Simplified and tweaked downscale/upscale threshold parameters.

* Added 30-frame history and 15-frame cooldown period after resolution change.

* Simplified and tweaked downscale/upscale threshold parameters.
@fabiangreffrath
Copy link
Owner

  • Added 30-frame history and 15-frame cooldown period after resolution change.

Is this frames or tics?

What about the idea to uncouple the target framerate from the screen's native framerate, because the latter might be inreasonably high? That is, don't change the resolution of the frame rate drops below e.g. 240 Hz, but only if it drops below e.g. 60 Hz.

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 26, 2025

  • Added 30-frame history and 15-frame cooldown period after resolution change.

Is this frames or tics?

It's frames.

That is, don't change the resolution of the frame rate drops below e.g. 240 Hz, but only if it drops below e.g. 60 Hz.

User can already set frame limiter to 60 and it will be target refresh for DRS. I'm not sure if we should force it. Usually PC with high refresh monitor also have fast CPU.

@fabiangreffrath
Copy link
Owner

User can already set frame limiter to 60 and it will be target refresh for DRS.

Fair enough. Should we rename it "target frame rate" in the menu then?

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 26, 2025

Fair enough. Should we rename it "target frame rate" in the menu then?

In SDL3 we can request a list of all available refresh rates. Maybe we should make a termo or some other UI element here, not sure yet.

@rfomin rfomin merged commit a6b0c1e into fabiangreffrath:master Jan 26, 2025
8 checks passed
@rfomin rfomin deleted the improve_drs branch January 26, 2025 15:36
@fabiangreffrath
Copy link
Owner

In SDL3 we can request a list of all available refresh rates. Maybe we should make a termo or some other UI element here, not sure yet.

We could still rename the parameter now, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants