Merge upstream #1113
Merged
Merge upstream #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* win midi: Fall back to default midi device * Simplify, avoid const string * Use strncasecmp * Formatting
When *not* using analog controls, let a move, turn or look sensitivity value of 0 disable that input. Restore Strife look sensitivity in setup.
* Add a build for macOS. * Integrate MSYS2 build. * Upload artifacts.
Co-authored-by: Michael Francis <4574480+mfrancis95@users.noreply.github.com>
Fixes chocolate-doom#1634 The additional check in `M_CheckParmWithArgs()` is necessary, since `myargv[i] = NULL` may have already happened when `I_Error()` is called which in turn calls `M_ParmExists(-nogui)`.
Add Strife PC speaker sound support
Introduce gamepad analog control
EMIDI events were skipped due to a copying mistake introduced by: chocolate-doom@833d0c2
This overhauls the states and uses critical sections to protect shared data between threads. This is intended to prevent race conditions, memory use after free, and so on. To implement this properly, some additional changes were required: - Refactored states - Instant pause/resume (no longer delayed until next callback) - Midi thread is created once and destroyed on shut down (no longer created/destroyed between songs)
win midi: Roundup of fixes
…obals Remove unused global char arrays `wadfile` and `mapdir`
These are only ever set, but never read, so they can just be removed.
…veljuststarted_global Remove unused `leveljuststarted` globals
This variable is only ever set, but never read, so it can just be removed.
This variable is only ever set, but never read, so it can just be removed.
…t` type These are only ever set, but never read, so they can just be removed. The type `st_stateenum_t` is then also unused and can be removed as well.
…um_t` type These are only ever set, but never read, so they can just be removed. The type `st_chatstateenum_t` is then also unused and can be removed as well.
Remove unused variables/datatypes/defines in st_stuff.{h,c}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.