Dev: update contributions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the function names related to auxiliary_coordinate conversion in the codebase. The changes include: - Renaming `auxiliary_coordinate_to_indices` to `aux_to_indices`. This update improves code readability and consistency by using more concise function names for coordinate conversion.
Split the tkinter GUI application class 'Board' into separate classes, 'BoardTile', 'BoardMenu', 'BoardEntry', 'BoardButton', and 'BoardLabel', to improve modularity and code readability. BoardTile: Represents a tile from the board with its logic. BoardMenu: Represents the contextual menu in the GUI. BoardEntry: Represents the square tile in the board. BoardButton: Represents a solve button. BoardLabel: Represents a result label. These changes enhance the maintainability and extensibility of the codebase, making it more organized and readable. Partially fixes #37
Refactor the initialization of the Board class, including buttons, tiles, and labels. The attributes and methods are organized to improve code readability and maintainability. - The buttons are initialized based on the value of SWAP, including 0 and 1 swaps. - The double_swap attribute is set based on the SWAP value. - Board buttons are now created with a separate function create_button to simplify the process. - Tiles and labels are initialized as separate methods. - Methods for setting and updating results on labels introduced for clarity. This refactoring improves code structure and maintainability without changing functionality.
Refactoring: Separation of Board Components
- Refactored the BoardButton class in boardbutton.py to improve readability and maintainability. - Added docstrings to the class and its methods for better documentation. - Reorganized code for button positioning and styling. This commit enhances the clarity and maintainability of the BoardButton class, making it easier to understand and modify in the future.
This commit separates the `MultHandler` class from `tkinterboard.py` into its own file `multhandler.py`. This modularization makes the codebase cleaner and more organized, promoting better code maintainability. Changes made in this commit: - Moved the `MultHandler` class to the `src/interfaces/multhandler.py` file. - Removed the `MultHandler` class definition from `tkinterboard.py`. No functional changes are made in this commit; it is purely a code organization update.
refactor: separate MultHandler class and other improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.