Share codegen binaries between all test runs #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
approved these changes
Jan 17, 2023
csegarragonz
force-pushed
the
share-codegen
branch
from
8d9f444 to
dd9e36c
Compare
csegarragonz
force-pushed
the
share-codegen
branch
from
dd9e36c to
1e671f2
Compare
csegarragonz
force-pushed
the
share-codegen
branch
from
1e671f2 to
26702f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GHA, we build
codegen_funcandcodegen_shared_objwithout sanitisers to generate machine code for test runs. Currently, we do it once for every test run in the matrix. This PR changes the behaviour to build it once per workflow run.Different jobs in the matrix run in parallel, so theoretically this change should not reduce overall runtime as the time we save in
tests(<Sanitiser>)is now spent inconan-cachemakingconan-cache + tests(<Sanitiser>)the same. However, this does reduce considerably the aggregate runtime.Take as an example a run without this fix and a run with this fix .