Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan for serial AMBE devices on Windows #1543

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Dec 21, 2022

Currently the AMBE engine doesn't scan for serial devices on Windows. There the comment:

 // Do not activate serial support at all for windows

Any idea why? Bad idea to send commands to all serial devices without knowing what they are?

This PR adds the scanning, which seems to find the device.

@f4exb
Copy link
Owner

f4exb commented Dec 22, 2022

Bad idea to send commands to all serial devices without knowing what they are?

You can't do otherwise. The USB vendor:serial 0403:6015 is just generic FTDI controller. Nothing to tell it is the AMBE dongle.

@f4exb f4exb merged commit 897ecc4 into f4exb:master Dec 22, 2022
@srcejon
Copy link
Collaborator Author

srcejon commented Dec 22, 2022

You can't do otherwise. The USB vendor:serial 0403:6015 is just generic FTDI controller. Nothing to tell it is the AMBE dongle.

Could just list the available serial ports though, and then let the user select one? QSerialPortInfo::availablePorts(); should list them.

Having said that, it is convenient that it only shows AMBE devices.

@srcejon srcejon deleted the ambe_serial_windows branch December 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants