Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APT Demod: Update to latest aptdec. #1459

Merged
merged 1 commit into from
Oct 1, 2022
Merged

APT Demod: Update to latest aptdec. #1459

merged 1 commit into from
Oct 1, 2022

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Sep 30, 2022

Updates to use the latest version of aptdec. This will require rebuilding of aptdec library dependency as the API has changed (as per Linux build instructions).

Removes obsolete zenith variable and adds support for visible image calibration.

Fixes #1422

…th variable. Add support for visible calibration.
@srcejon
Copy link
Collaborator Author

srcejon commented Sep 30, 2022

The docker build looks like it has failed due to using the old version of aptdec.

@f4exb
Copy link
Owner

f4exb commented Sep 30, 2022

It should pick up the latest shouldn't it? https://github.com/f4exb/sdrangel/blob/master/external/CMakeLists.txt#L773

@srcejon
Copy link
Collaborator Author

srcejon commented Sep 30, 2022

It should do, and the other two were OK. Is it possible to run it again?

@f4exb f4exb merged commit 3e54c92 into f4exb:master Oct 1, 2022
@f4exb
Copy link
Owner

f4exb commented Oct 1, 2022

It is an issue with Appveyor insisting to use a cached version:

#23 [aptdec 2/2] RUN git clone https://github.com/srcejon/aptdec.git     && cd aptdec     && git checkout libaptdec     && mkdir build; cd build     && cmake -Wno-dev -DCMAKE_INSTALL_PREFIX=/opt/install/aptdec ..     && make -j8 install
#23 sha256:700ccc8b5e68073f4a5922342f140d0fc9eba212dd1750f4c2c5fd2bf1407dd2
#23 CACHED

I does not make any sense and I don´t know how to tell it not to use a cache,

@f4exb
Copy link
Owner

f4exb commented Oct 1, 2022

@srcejon srcejon deleted the fix_1422 branch December 22, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aptdec removed apt_image_t.zenith
2 participants