Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum: Add peak power and frequency in info bar #1437

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Sep 22, 2022

This patch adds the peak power and frequency into the spectrum info bar.

image

Currently always enabled, but could add a button to make it optional if desired.

@f4exb
Copy link
Owner

f4exb commented Sep 22, 2022

Currently always enabled, but could add a button to make it optional if desired.

I am not definite on this let's give it a bit of practice

@f4exb f4exb merged commit 31565b5 into f4exb:master Sep 22, 2022
@f4exb
Copy link
Owner

f4exb commented Sep 23, 2022

I understand the functionality and motivation but I see a few shortcomings:

  • it is not tremendously useful if the signals are transient
  • frequency display is down to the Hz regardless of the FFT bin size. I think precision should be down to 10^log10(binSize). For example if bin size is between 10 Hz and 100Hz it should be enough to have a precision down to 10Hz. This would limit distraction with the low digits changing all the time and limit width to only what is useful. Note that this may apply to the center frequency display too and I am not sure it is presently.
  • the space occupied is not always void. When markers are displayed and the frequency of the marker is above the high limit of the bandwidth then frequency is displayed in the same space resulting in a garbled display. See screenshot next

image

So at least in a first approach yes this should be made optional.

For the longer run... I already thought of improving the markers so that they are not fixed in frequency but can be made to track the bin with maximum magnitude as one can find on many spectrum analyzers. One can imagine tracking the current max or the max of max depending on the choice of marker type: https://github.com/f4exb/sdrangel/blob/master/sdrgui/gui/spectrummarkers.md#9-marker-type Thus the max of transient signals could be maintained.

Then one could choose which marker data to display on the top right corner thus achieving the same functionality and more and also solving the display mixing. There are many things on the plate right now and for now just making the display optional would be enough.

I will open a specific issue for markers enhancement.

@srcejon
Copy link
Collaborator Author

srcejon commented Sep 23, 2022

I'll add a patch to make it optional.

@srcejon srcejon deleted the spectrum_peak branch December 22, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants