Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start/stop all devices in workspace button in toolbar. #1394

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Aug 27, 2022

This PR is to primarily add a "start/stop all devices in workspace" button, to the workspace toolbar.

image

I find this useful in a couple of cases:

  • When recording/playing back data from multiple devices, it helps to sync them in time. (Not perfect, but better than by clicking start individually)
  • For some modes, device settings don't need to be adjusted, so the device GUI can be hidden after setup - but start/stop button is still needed. Having it on the toolbar allows device GUI space to be used for something else.
  • As with the latency example on the mailing list the other day, it can be useful to stop all devices at the same time to compare spectra.

In order to keep the state / colour of the toolbar button consistent with the state of the devices, I have added a signal in the device API (stateChanged) that is emitted whenever the device state changes.

This signal can also be used to eliminate the state polling that currently uses a timer in the device GUIs. Just as an example, I've updated the RTL SDR GUI to use this. If you think this patch is OK, then I can update some of the others to work the same.

… signal. Use in RTL SDR GUI for updating device state
@f4exb f4exb merged commit 01e75b3 into f4exb:master Aug 29, 2022
@srcejon srcejon deleted the start_stop_all branch September 16, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants