Spectrum markers: Allow both types to be displayed at the same time #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two two small changes to spectrum markers.
Firstly, it adds an option of All, to allow both Spectrum markers and Annotations to be displayed at the same time. (MarkersDisplay enum changed to a bitmask in case we want more permutations of additional marker types in the future).
Secondly, it adds an additional option of Text for the Annotation markers, so that the Annotation text is displayed in the header, without the full height bandwidth markers being drawn (just my personal preference!)
Also, I made a small change, so that the bandwidth lines are always drawn when annotations are visible - however, unless the setting is full, the lines are drawn only in the header area, so that you can see where bands start and finish if they are contiguous. If you don't like this, I'm happy to change it back / tweak it further.