Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum: Allow frequency scrolling #1305

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Jun 24, 2022

This patch allows a user to adjust center frequency up or down in a main spectrum by:

  • Holding down the middle mouse button and moving the mouse left or right
  • Moving the mouse outside of the spectrum area when dragging a channel marker.

For me, this makes it much quicker and easier to move to frequencies that are just out of range.

It works quite well on RTL SDR & USRP (for the latter, it's nearly as smooth as moving the channel marker) - but is a little slow on SDRplay.

Note, this works by GLSpectrum emitting a signal requesting a change of center frequency - The change of device frequency is handled by MainSpectrumGUI - so GLSpectrum doesn't need to know whether it is connected to a device or something else.

@srcejon
Copy link
Collaborator Author

srcejon commented Jun 24, 2022

On a different subject, did you mean to create the new waterfall.png and waterfall_3d.png icons so big? They're 480x480 pixels.

@f4exb
Copy link
Owner

f4exb commented Jun 24, 2022

On a different subject, did you mean to create the new waterfall.png and waterfall_3d.png icons so big? They're 480x480 pixels.

Looks like they were left at their original size when drawing them in Gimp.

@f4exb
Copy link
Owner

f4exb commented Jun 24, 2022

To be used with care... in a multi channel configuration the change in the device frequency affects all channels. You may want this or not.

@f4exb f4exb merged commit c01514d into f4exb:master Jun 24, 2022
f4exb added a commit that referenced this pull request Jun 24, 2022
@f4exb
Copy link
Owner

f4exb commented Jun 24, 2022

I think it is better if MainWindow takes care of device center frequency setting. Moreover it has access to the DeviceAPI object which can provide access to the virtual setCenterFrequency method of source and device sinks. This can provide support to a wider range of devices and maybe improve performance. I have corrected the code in that sense so that MainSpectrumGUI relays the signal of GLSpectrum adding the device set index for commodity and is later caught and processed in the MainWindow.

@srcejon
Copy link
Collaborator Author

srcejon commented Jun 24, 2022

Ok, sounds good. Thanks for updating the docs!

@srcejon srcejon deleted the spectrum_scrolling branch July 18, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants