Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android build #382

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Add Android build #382

merged 1 commit into from
Sep 3, 2022

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Aug 30, 2022 •
edited
Loading

Part of #173
This PR enables Android (x64 and ARM) build on the CI.

@Meakk Meakk requested a review from mwestphal August 30, 2022 22:10
@Meakk Meakk self-assigned this Aug 30, 2022
@Meakk Meakk force-pushed the android-build branch 2 times, most recently from 0fef607 to b213ca5 Compare August 30, 2022 22:19
@codecov
Copy link

codecov bot commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #382 (9f911a9) into master (46df21f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9f911a9 differs from pull request most recent head 0ce3d70. Consider uploading reports for the commit 0ce3d70 to get more accurate results

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          91       91           
  Lines        4524     4524           
=======================================
  Hits         4292     4292           
  Misses        232      232
Impacted Files Coverage Δ
.../VTKExtensions/Applicative/vtkF3DObjectFactory.cxx 100.00% <ø> (ø)
library/VTKExtensions/Rendering/vtkF3DRenderer.cxx 99.74% <ø> (ø)
library/src/window_impl.cxx 100.00% <ø> (ø)
...ry/VTKExtensions/Readers/vtkF3DGenericImporter.cxx 95.51% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mwestphal
mwestphal requested changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes required

@Meakk Meakk force-pushed the android-build branch 5 times, most recently from d98e3cd to 9e5d802 Compare September 2, 2022 18:42
mwestphal
mwestphal requested changes Sep 3, 2022
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes required

@Meakk Meakk merged commit 52c68e7 into f3d-app:master Sep 3, 2022
@Meakk Meakk deleted the android-build branch September 3, 2022 10:46
@Meakk Meakk mentioned this pull request Sep 3, 2022
Closed
10 tasks
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@Meakk
Add Android build (f3d-app#382)
d07074d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meakk @mwestphal