Renamed dry-run argument to no-config #1690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for issue f3d-app#1637 this will make it clearer as dry-run does not do what most people expect (not make changes). This new argument will lead people to search for no-render if they actually intend to use the feature that most projects refer to as dry-run
|
Thats nice but you may also want to fix issue #1637. Afaik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #1637
this will make it clearer as dry-run does not do what most people expect (not make changes).
This new argument will lead people to search for no-render if they actually intend to use the feature that most projects refer to as dry-run.
no-config is a better name for this arg.