Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit any #64

Merged
merged 8 commits into from
Apr 12, 2019
Merged

Fix implicit any #64

merged 8 commits into from
Apr 12, 2019

Conversation

fraparisi
Copy link
Contributor

If typescript is configured for "noImplicitAny" the older types generate error in compilation.

f
f requested changes Dec 21, 2018
View reviewed changes
Copy link
Owner

@f f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Can you please respect the code styling and update the commit? We use 2 space tab with spaced curlies.

@fraparisi
Copy link
Contributor Author

@f now should be fine :)

@yoyoys
Copy link
Contributor

yoyoys commented Jan 4, 2019 •
edited
Loading

I think waitFor can be a generic like this.

waitFor<T extends Function | AsyncFunction>(waiter, callback: T, forceSync?: false): T;

@fraparisi
Copy link
Contributor Author

@yoyoys updated thanks.

@brantwills
Copy link

Ran into this myself today - many thanks for addressing and all the work put into vue-wait!

@fraparisi
Copy link
Contributor Author

@f any news on this?
Thanks in advance

@fraparisi fraparisi mentioned this pull request Mar 11, 2019
Open
@f f merged commit ee61dcf into f:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f f f requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fraparisi @yoyoys @brantwills @f