feature: QuizVisualization 컴포넌트 grid 생성 및 캐릭터 움직임 조작, QuizEditor 컴포넌트 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return없는 함수 배열에 리스트저장, useQuiz useAnswer상태관리저장.
|
p1) |
new-deni
reviewed
Feb 1, 2025
src/components/QuizEditor.tsx
Outdated
Comment on lines
16
to
22
| let executedList: string[] = [] | ||
| currentQuiz.commands.forEach((cmd) => { | ||
| (window as any)[cmd.name] = () => { | ||
| executedList.push(cmd.name); | ||
| return cmd.function(); | ||
| }; | ||
| }); |
There was a problem hiding this comment.
이 부분을 읽어선 뭘 하고자 하는지 잘 모르겠는데 순수했던 executeCode랑 꼭 엮였어야 하나요?
new-deni
reviewed
Feb 1, 2025
src/store/useQuiz.ts
Outdated
Comment on lines
21
to
22
| userAnswer: string[] | string; | ||
| setUserAnswer: (answer: string[] | string) => void; |
There was a problem hiding this comment.
여기는 왜 string일 수도 있고 string[]일 수도 있나요? 타입이 나뉘면 힘들어질 텐데요.
new-deni
reviewed
Feb 1, 2025
src/components/QuizVisualization.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| if (!userAnswer || !Array.isArray(userAnswer) || userAnswer.length === 0) return; | ||
| let newPos = { ...startPosition }; |
There was a problem hiding this comment.
여기처럼 let으로 변수를 선언하고 특정 조건일 때 변수는 바꾸는 코드가 여기저기 있는데 무슨 뜻인지 잘 모르겠어요. let을 사용할 일이 보통 잘 없는데 꼭 이런 흐름을 따라야 하나요?
new-deni
approved these changes
Feb 1, 2025
new-deni
reviewed
Feb 3, 2025
src/components/QuizVisualization.tsx
Outdated
| let newPos = { ...startPosition }; | ||
| userAnswer.map((command, index) => { | ||
| setTimeout(() => { | ||
| if (command === "forward") { | ||
| if (command === 'forward') { |
new-deni
reviewed
Feb 5, 2025
| @@ -19,8 +19,10 @@ export const Header = () => { | |||
| const parsedQuizId = parseInt(quizId || '', 10); | |||
| if (isNaN(parsedQuizId) || parsedQuizId < FIRST_QUIZ_ID) { | |||
| navigate(`/quizzes/${FIRST_QUIZ_ID}`, { replace: true }); | |||
| fetchQuizData(FIRST_QUIZ_ID.toString()); | |||
There was a problem hiding this comment.
이럴수가.. 데이터의 아이디를 uuid 같은 걸로 바꿔서 아이디 타입 자체를 스트링으로 관리하라는 말이었어요.
There was a problem hiding this comment.
앗 .. 넵 확인했습니다 수정하겠습니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: QuizVisualization 컴포넌트 문제생성(grid), 캐릭터 움직임 조작, QuizEditor컴포넌트 return없는 함수 배열에 리스트저장, useQuiz useAnswer상태관리저장.