Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added cache to food project #139

Open
wants to merge 1 commit into
base: feat/added-cache
Choose a base branch
from
Open

feat: Added cache to food project #139

wants to merge 1 commit into from
+71 −5

Conversation

koreanMike513
Copy link
Collaborator

  • foods 프로젝트에 cache 를 추가하였습니다.
  • food 리스트의 경우에는 custom한 FoodSearchCondition 객체를 base로 하여 keyGenerator 를 적용하였습니다.

@koreanMike513 koreanMike513 added the enhancement New feature or request label Feb 24, 2025
@koreanMike513 koreanMike513 self-assigned this Feb 24, 2025
@github-actions GitHub Actions
Copy link

HCP Terraform Plan Output

```
Plan: 35 to add, 0 to change, 0 to destroy.
```
[HCP Terraform Plan](https://app.terraform.io/app/Joyeuse_Planete/workspaces/Joyeuse_Planete/runs/run-xX3hDK8YKm4xwn48)

f-lab-troy
f-lab-troy approved these changes Feb 25, 2025
View reviewed changes
foods/src/main/java/com/f_lab/joyeuse_planete/foods/config/RedisConfig.java

protected RedisCacheConfiguration redisCacheConfiguration() {
return RedisCacheManager.builder().cacheDefaults()
.entryTtl(Duration.ofMillis(Long.parseLong(THIRTY_MINUTES)))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 로드테스트를 통해 ttl값을 튜닝하는 방법을 고려해보면 좋습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees

@koreanMike513 koreanMike513

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koreanMike513 @f-lab-troy